38654158899
84%

Ran 14 Oct 2026 11:47PM UTC

Jobs 1

Files 59

Run time 1min

Badge

Embed ▾

Committed 14 Oct 2026 11:27PM UTC coverage: 83.519% (+0.1%) from 83.394%

Build # 38654158899

Build Type

push

github

Committed by

web-flow

Commit Message

feat(chart): validate runtimeRequiredTaint with a values schema (#836)

* feat(chart): validate runtimeRequiredTaint with a values schema

The operator refuses to start when the runtime-required taint key has a
DNS prefix or exceeds 53 characters, but the chart accepted any value, so
the error only surfaced as a crash-looping pod after helm had already
rolled it out. Add values.schema.json constraining
controllerManager.manager.env.runtimeRequiredTaint to exactly what
ParseTaints and Validate accept, so helm install/upgrade fails at render
time instead.

The helm-template chainsaw test feeds the schema the accept/reject cases
Validate enforces, and Validate points at the schema so the two change
together.

Closes #817

Signed-off-by: Brian Lockwood <lockwobr@gmail.com>

* fix(chart): require runtimeRequiredTaint in the values schema

Helm drops a null key before validating, so runtimeRequiredTaint: ~ skipped
the pattern and rendered RUNTIME_REQUIRED_TAINT as an empty env var.
go-envconfig only applies its default when the variable is unset, so the
operator read "" and refused to start. Mark the property required so a null
value fails at render time like any other invalid one.

Signed-off-by: Brian Lockwood <lockwobr@gmail.com>

---------

Signed-off-by: Brian Lockwood <lockwobr@gmail.com>

Coverage Stats

10054 of 12038 relevant lines covered (83.52%)

7.62 hits per line

Coverage Regressions

Lines	Coverage	∆	File
4	84.15	0.04%	operator/internal/controller/skyhook_controller.go
3	80.34	0.85%	operator/internal/controller/mirror_controller.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	38654158899.1	14 Oct 2026 11:47PM UTC	59	83.52	GitHub Action Run

NVIDIA / nodewright / 38654158899
84%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 38654158899

NVIDIA / nodewright / 38654158899 84%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 38654158899

NVIDIA / nodewright / 38654158899
84%

README BADGES
x