ben-manes / caffeine / #5826

100%

master: 100%

Build Type

push

github

Committed by ben-manes

Commit Message

remove the JDK's timer when the pacer cancels

Scheduler.systemScheduler() went through delayedExecutor, which keeps
no handle to its delayed task, so the pacer's cancel left that task
queued until its original fire time. A cache that emptied and refilled
stranded one task per cycle, about 900 bytes each, for up to its
expiration duration.

The system scheduler now arms an internal future with orTimeout, whose
timeout completes the returned future and submits the task. Completing
the returned future, as a cancel does, completes the timer normally,
the only completion on which JDK 11, and 17 before 17.0.14, remove it.

The JDK-seam audit's findings that need no change are recorded as
rulings, and the skill is kept for manual runs.

Coverage Stats

4826 of 4834 branches covered (99.83%)

12 of 12 new or added lines in 1 file covered. (100.0%)

2 existing lines in 2 files now uncovered.

9277 of 9279 relevant lines covered (99.98%)

1.0 hits per line