dtcenter / METplus / 38639107129

93%

push

github

Feature #3358 remove warning and error (#3365)

* Per #3455, rename METplus config ENSEMBLE_STAT_OBS_ERROR_FLAG to ENSEMBLE_STAT_OBS_ERR_FLAG and env var MET_OBS_ERROR_TABLE to MET_OBS_ERR_TABLE

* Per #3358, rename METplus config TIME_OFFSET_WARNING to TIME_OFFSET_WARN and env var METPLUS_TIME_OFFSET_WARNING to METPLUS_TIME_OFFSET_WARN to avoid WARNING in log output. Legacy config names are still supported and the old env var is flagged as deprecated in wrapped MET config files

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Per #3358, log deprecation warnings for old config names, add v13.0.0 upgrade instructions, and avoid flagged words in use case and log output

- Add CommandBuilder.warn_if_deprecated_config and warn when TIME_OFFSET_WARNING, *_TIME_OFFSET_WARNING, ENSEMBLE_STAT_OBS_ERROR_FLAG, or ENSEMBLE_STAT_MET_OBS_ERROR_TABLE are set
- Add upgrade instructions for renamed config variables, wrapped MET config env vars, and obs_err table files
- Rename obs_error_table_V8.0.txt to obs_err_table_V8.0.txt in EnsembleStat HRRRE use case
- Remove commented TIME_OFFSET_WARN lines from TCPairs and MTD use cases that have no effect
- Reword StatAnalysis debug message and use case script messages to avoid "empty" and "ERROR"
- Add note to Contributor's Guide to avoid flagged words in use case log output

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Per #3358, add support for setting all obs_err dictionary items in EnsembleStat

Replace METPLUS_OBS_ERR_FLAG with METPLUS_OBS_ERR_DICT and add METplus config
variables ENSEMBLE_STAT_OBS_ERR_[DIST_TYPE/DIST_PARM/INST_BIAS_SCALE/
INST_BIAS_OFFSET/MIN/MAX]. Legacy ENSEMBLE_STAT_OBS_ERROR_FLAG is still
supported. Update docs, upgrade instructions, and unit tests. Fix docstring
for nicknames in _parse_item_info.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* add a note to encourage users to avoid using user-defined wrapped MET config files

* create helper function to reduc... (continued)

35 of 35 new or added lines in 5 files covered. (100.0%)

9836 of 10661 relevant lines covered (92.26%)

1.85 hits per line