NVIDIA / nodewright / 38628268458
84%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 59
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.547% (+0.1%) from 83.406%
38628268458

push

github

web-flow 
fix(ci): route Docker Hub pulls through mirror.gcr.io (#816)

GitHub-hosted runners share egress IPs, and Docker Hub rate-limits
anonymous pulls per IP, so CI fails at whatever step next touches
Docker Hub. helm-tests failed this way when ctlptl pulled registry:3
with "toomanyrequests".

CI pulls from Docker Hub in four places, and each needs its own fix:

- The runner's dockerd. The new setup-docker-hub-mirror action adds
  mirror.gcr.io to daemon.json and restarts dockerd. That setting is not
  relied on for a plain docker pull, so the images kind pulls are also
  pulled from the mirror by name and retagged; kind skips its pull when
  the image is present. ctlptl now asks kind for that bare tag through
  kindExtraCreateArguments, because the digest-pinned tag ctlptl passes
  by default does not match a retagged copy.
- BuildKit. The docker-container driver's buildkitd never reads
  daemon.json, so the action writes a buildkitd.toml that mirrors
  docker.io. The BuildKit and binfmt images are handed to
  setup-buildx-action and setup-qemu-action only after the mirror has
  served them, since those inputs have no fallback of their own.
- containerd inside the kind nodes. With DOCKER_HUB_MIRROR set (the
  action exports it), make setup-kind-cluster writes a hosts.toml for
  docker.io into every node.
- Pulls outside the action's reach. The runner pulls the agent
  unit-test job container before any step runs, so it is named on
  mirror.gcr.io directly. ctlptl pulls registry:3 only when it is
  missing, so CI pre-pulls it from the mirror with the node image.

Every path except the job container falls back to Docker Hub when the
mirror misses. ECR Public is no alternative: it caps anonymous pulls
per IP too ("Data limit exceeded"). validate-kind-node-image also
skips its Docker Hub manifest read when the tag is already local,
which it is in CI after the pre-pull.

Signed-off-by: Brian Lockwood <lockwobr@gmail.com>

10029 of 12004 relevant lines covered (83.55%)

7.62 hits per line

Coverage Regressions

Lines Coverage ∆ File
1
84.62
0.72% operator/internal/controller/skyhook_controller.go
Jobs
ID Job ID Ran Files Coverage
1 38628268458.1 59
83.55
GitHub Action Run
Source Files on build 38628268458