uber / h3-go / 38629144126
100%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 20
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
38629144126

push

github

web-flow 
bench: use b.Loop in every benchmark and drop the result sinks (#168)

The root package's benchmarks still counted to b.N and stored each result
in a package-level variable so the compiler could not discard the call.
Since Go 1.24 b.Loop does both jobs: it keeps the arguments and results of
every call written between its braces alive, and it resets the timer
before the first iteration, so the sinks and the one explicit ResetTimer
are redundant. The module already requires Go 1.24 and the other
benchmarks already use b.Loop.

Convert the nineteen b.N loops, remove the sink variables in bench_test.go,
h3_bench_test.go and x/h3go/latlng_test.go, and keep only the inputs at
package scope so they are not constant-folded into the measured call.
Error-returning calls are written as blank assignments for errcheck; the
keep-alive applies to assigned values as well as to bare calls.

paritytest is unchanged. Its benchmarks already use b.Loop, but the
measured call sits inside a closure invoked from the loop, outside the
keep-alive's syntactic scope, so its sink helper still has a job.

The numbers move for the sub-nanosecond benchmarks only. b.Loop costs
about two nanoseconds per iteration on this machine (its inlined fast
path plus the keep-alive store), which a b.N loop with a global sink did
not pay: Resolution goes from 0.35 to 2.2 ns/op and IsValid from 2.3 to
2.7, while NumCells, already on b.Loop, stays at 2.3. LatLngToVec3,
LatLngToCell and GridDisk are unchanged within noise. Comparisons across
this commit on the bit-twiddling benchmarks are therefore not meaningful;
comparisons after it are.

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

4550 of 4550 relevant lines covered (100.0%)

4166589.69 hits per line

Jobs
ID Job ID Ran Files Coverage
1 Go- - 38629144126.1 20
100.0
GitHub Action Run
Source Files on build 38629144126