kubeflow / trainer / 38611861792

77%

push

github

fix(controller): break ties when picking the best OptimizationJob trial (#4192)

ExtractBestResult kept the first trial it saw when objective values were
equal. The trial list comes from the cache and its order changes between
reconciles, so status.result could point at a different trial each time,
even after the job completed.

On a tie, pick the trial with the earlier creationTimestamp, then the one
with the smaller name. The result no longer depends on list order.

Fixes #4169

Signed-off-by: ISystemNoTool <btxu-db@outlook.com>

7 of 7 new or added lines in 1 file covered. (100.0%)

3135 of 4290 relevant lines covered (73.08%)

0.73 hits per line