temporalio / sdk-java / #405

71%

master: 75%

Build Type

push

github

Committed by web-flow

Commit Message

Resolve property placeholders in worker names (#3143)

The workers attribute of @WorkflowImpl, @ActivityImpl and
@NexusServiceImpl was used verbatim, while taskQueues already went
through the Spring environment's placeholder resolution. A worker name
such as ${my.worker.name} was therefore looked up literally and startup
failed with BeanDefinitionValidationException, which prevented sharing
a workflow module between services with different worker names.

Resolve placeholders in worker names before the worker lookup, the same
way task queues are resolved, and document it on the annotations.

Fixes #2747.

Coverage Stats

7964 of 13784 branches covered (57.78%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

3 existing lines in 1 file now uncovered.

32254 of 44987 relevant lines covered (71.7%)

0.72 hits per line