kubernetes-sigs / kubebuilder / 38604767541

89%

push

github

🐛 (CLI): report a bad `--plugins` value on `create`/`alpha` and complete the flags of the project plugins (#6070)

* fix(cli): report a bad plugins flag on command groups and complete the flags of the project plugins

The create and alpha command groups could not run, so Cobra skipped the root
check and printed their help with exit code 0 even when the plugins flag was
malformed. They now run and print their help, so the malformed flag is
reported. They still do not use the project configuration.

A completion request never read the project configuration, so TAB offered the
flags of the default plugin chain instead of the plugins the project layout
names. Completion now reads the configuration for the commands the plugin
chain builds (init, edit, create api and create webhook). A configuration that
cannot be used still falls back to the defaults, and completing other commands,
such as alpha generate, still leaves PROJECT unread.

* fix(cli): mark command groups on the command and cover them in every project state

A command group is now marked with an annotation by asCommandGroup, which also
sets the function that prints its help, and checkCommandLine reads that
annotation. The list of group names in root.go is gone, so a new group cannot
be added in one place and missed in the other.

New specs check that create and alpha print their help with no PROJECT and
with each PROJECT that cannot be used, that a bad plugins value on them is
reported in every project state without mentioning the configuration, that
help asked for next to the bad value is still printed, and that completing the
flags of create api falls back to the default plugins without opening a
PROJECT that is not a regular file.

34 of 38 new or added lines in 4 files covered. (89.47%)

8945 of 10230 relevant lines covered (87.44%)

384.08 hits per line