pulibrary / bibdata / 340bc163-f6ce-42e9-9ddc-857309b460c8

92%

main: 92%

Build Type

Pull #3602

circleci

Committed by sandbergja

Commit Message

Refactor: use function composition for some data processing

This is intended to help in situations like the following:
```
remove_punctuation(normalize_characters(remove_spaces(my_string)))
```
...where it is not immediately obvious that we first remove spaces,
then normalize characters, and finally remove punctuation (at least,
I have to think about it for a second).

Instead, we can now do:
```
pipe!(remove_spaces, normalize_characters, remove_punctuation)(my_string)
```
...where the order is very clear.

It works in some cases, but not others.  For example, if
`normalize_characters` in the example above returned an
owned string, but `remove_punctuation` accepted and
returned borrowed references, we would get a compiler error.

My thoughts are that this still can make some scenarios clearer,
what do you think?

Pull Request Pull Request #3602: Refactor: use function composition for some data processing

Coverage Stats

60 of 96 new or added lines in 11 files covered. (62.5%)

6 existing lines in 3 files now uncovered.

12929 of 14098 relevant lines covered (91.71%)

80.32 hits per line