astronomer / astro-cli / 38581372048

58%

main: 45%

Build Type

push

github

Committed by web-flow

Commit Message

Guard removed 1.x commands in CI, and give bundle create/update/delete -o json (#2291)

* Guard every removed 1.x command in CI, and say "removed in Astro CLI v2" everywhere

cmd/testdata/v1_commands.tsv is the inventory of every visible 1.x command,
in the trees v1_flags.tsv names (astro, astro-hosted, apc). Only the tests
read it. TestEveryV1CommandStillRunsOrSaysWhatReplacedIt resolves each path
against its v2 trees (APC at both ends of its version gates) and fails on
one that stops at a command with words left over: a command dropped without
a stub, or renamed without its 1.x name as an alias. Every stub a path
reaches is run with the other hooks disarmed, in text and under -o json:
a usage error, "was removed in Astro CLI v2" and a replacement (or none),
no pre-run, and the error object on stdout.

What it found, now fixed:
- `astro dev` failed with exit 1, not 2, and its json payload lacked the
  error object's code and kind. It is a usage error now, and its payload
  leads with error, code and kind before the mapping.
- `astro env ... create|update` ran the env group's pre-run (project and
  login) before the guidance; they skip it, as the deployment stubs do.
- The deployment and env stubs said "removed in v2"; they say "removed in
  Astro CLI v2", as dev, run and the removed flags do. `deployment pool`
  says there is no replacement in the CLI yet.

The assembled root's local commands publish to the root's out (os.Stdout in
production), so a test of the root reads what they print.

Co-Authored-By: Claude <noreply@anthropic.com>

* Give astro deployment bundle create, update and delete -o json, and unhide them

They were hidden only because they printed prose and every visible command
offers --output json. Now, under -o json:

- create and update publish the bundle as the change left it, in the shape
  bundle list gives each one (deployment-bundle.json);
- delete publishes what it deleted: id, deployment_id and action "deleted",
  as the deplo... (continued)

Coverage Stats

187 of 232 new or added lines in 15 files covered. (80.6%)

1 existing line in 1 file now uncovered.

40350 of 69748 relevant lines covered (57.85%)

245.2 hits per line