safe-global / safe-client-gateway / 38577902981

91%

push

github

fix: prefix counter keys and let setCounter overwrite (#3610)

* fix(cache): prefix setCounter keys and let it overwrite

setCounter wrote the key without the cache key prefix, while getCounter reads the prefixed key, so a value written by setCounter was never read back. It also used NX, so a second write was silently ignored. setCounter has no caller on main yet; the Safenet payer nonce cache (#3564) needs both fixes.

* fix(cache): prefix increment keys

increment wrote, expired and read the key without the cache key prefix, while getCounter reads the prefixed key.

* test(cache): cover counter keys with a non-empty prefix

4635 of 5392 branches covered (85.96%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

11811 of 12890 relevant lines covered (91.63%)

365.42 hits per line