astronomer / astro-cli / 38496205402
61%
main: 45%

LAST BUILD BRANCH: v2-build-on-locked-runtime
DEFAULT BRANCH: main
Ran
Jobs 1
Files 333
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 57.836%. Remained the same
38496205402

push

github

web-flow 
Don't fail requests sent while a project's Airflow restarts (#2308)

* Open a fresh connection to a project's Airflow on every request

The proxy kept connections to each project's Airflow alive. A project restart brings Airflow back on the same port, and a pooled connection from before the restart reaches a process that is gone, so the first request after a restart hung instead of reconnecting. Astro Desktop's proxy turned keep-alives off for this reason; the shared proxy now does too, which matters once the desktop's projects are served by it. These are loopback connections, so one per request costs next to nothing.

Co-Authored-By: Claude <noreply@anthropic.com>

* Show the launch page for every way a restarting backend hangs up

A connection accepted and closed before any response is a restarting Airflow, and the transport reports it either as a bare EOF or, when it sees the close before writing the request, as net/http's unexported errServerClosedIdle. The second was not recognized, so on Linux about a third of those requests got plain text instead of the launch page; TestABackendThatHangsUpShowsABrowserTheUnavailablePage failed whenever it hit that shape. It has no type or sentinel, so it is matched by its text.

Also corrects why keep-alives are off. A connection pooled from before a restart does not hang: Go replays a GET on a fresh one, but a POST, PATCH or DELETE sent in the moment before the transport notices the close fails as "Backend unavailable" although the backend is up. A new test sends a POST straight after a backend comes back on the same port, twenty times, and fails on the first run with keep-alives on.

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

40242 of 69579 relevant lines covered (57.84%)

234.59 hits per line

Jobs
ID Job ID Ran Files Coverage
1 38496205402.1 333
57.84
GitHub Action Run
Source Files on build 38496205402