ArduPilot / MethodicConfigurator / 38482541294

94%

push

github

fix(mavftp): prevent GUI starvation during large file downloads

Packet-level progress reports could overwhelm the GUI's unbounded queue.
Draining and repainting every queued update monopolized the Tk thread,
leaving the interface unresponsive while downloads continued successfully
in the background.

Replace queued progress history with a lock-protected latest-progress
snapshot and a separate completion slot:
- Render at most one progress snapshot per 50 ms poll.
- Skip unchanged current/total values.
- Keep pending progress storage bounded regardless of packet rate.
- Preserve final progress before delivering completion or errors.
- Release the lock before invoking GUI callbacks.
- Guard against reentrant polling during progress rendering.
- Reset duplicate-progress tracking for each new task.

Stop raising the progress window on every update while retaining its
initial raise when first shown.

Add deterministic regression tests covering:
- Progress flooding across three simulated large downloads.
- Successful and failed completion after a progress flood.
- New progress arriving while the GUI renders.
- Duplicate reports and changes to the progress total.
- Progress tracking reset between download attempts.
- Reentrant polling and completion ordering.
- Initial window raising without repeated stacking-order changes.

Confirm the starvation and repeated-raising regressions fail before
their respective fixes and pass afterward.

Signed-off-by: Dr.-Ing. Amilcar do Carmo Lucas <amilcar.lucas@iav.de>

6970 of 8222 branches covered (84.77%)

25002 of 27249 relevant lines covered (91.75%)

2.74 hits per line