supabase / storage / 38490434153

86%

push

github

fix: abort TUS connections that receive no bytes within the idle timeout (#1478)

## What kind of change does this PR introduce?

Bug fix

## What is the current behavior?

If an open TUS request stops sending bytes, but never sends a FIN or RST
(the TCP signals that close a connection) the server keeps the upload's
database lock open forever. This can slow down the database and block
other uploads.

This can happen if the client's network dies or the app gets
backgrounded.

## What is the new behavior?

Close the connection if no bytes are received for 60 seconds
(configurable). This releases the lock automatically, even if the client
never sends a FIN/RST and never comes back.

7610 of 9445 branches covered (80.57%)

Branch coverage included in aggregate %.

34 of 35 new or added lines in 1 file covered. (97.14%)

13276 of 15031 relevant lines covered (88.32%)

854.51 hits per line