NVIDIA / nvidia-container-toolkit / 38473151400

44%

main: 45%

push

github

Fix the config option name in the unsupported-capability panic

getConfigOption reflects over **hookConfig to read the toml tag of a field.
FieldByName panics on anything that is not a struct type, so the call that
was meant to name the option in the panic message panics first:

  reflect: FieldByName of non-struct type **main.hookConfig

The one caller is the invalid-capability branch in getHookConfig, so a
container start with a bad supported-driver-capabilities reports a
reflection error instead of naming the option and the value. The existing
test only asserts that something panics, so it stays green either way.

Reflect over hookConfig. FieldByName walks the embedded *Config, so the
tag comes back as supported-driver-capabilities.

Predates the modernize pass: reflect.TypeOf(&c) had the same problem, with
c already a *hookConfig.

Signed-off-by: Dmitry Voropaev <dy.voropaev@gmail.com>

1 of 1 new or added line in 1 file covered. (100.0%)

5984 of 13556 relevant lines covered (44.14%)

0.44 hits per line