solidjs / solid / 38446084125

78%

main: 89%

push

github

fix(attribution): GRAPH_GROWTH also requires what outlived each navigation to climb (#4007) (#4020)

GRAPH_GROWTH compared the whole graph's size at each settle of a route
pattern, so a page whose correctly owned content is bigger on each visit
(/rows/1, /rows/3, /rows/5) read as a leak although leaving disposed it.

While graphGrowth is on, a non-initial navigation now walks the graph as it
opens and adds every node to a WeakSet; its settle's walk also counts the
nodes from that set still alive (an edge when both ends are) and drops the
set. A series reports only when it climbs in the totals, as before, and in
that survived count. A navigation that stays on the route pattern the app
is on continues the visit and is not compared. The finding's data gains
`survived` beside `history`; the message shows both.

Engine-only: prod artifacts byte-identical. The observe + attribution size
scenario grows +230 B brotli (+594 B minified); cap raised with an audit
note pending the maintainer's acceptance.


Claude-Session: https://claude.ai/code/session_01NcUAu8BQ6Xsf8XRBhr9V1w

Co-authored-by: Claude <noreply@anthropic.com>

750 of 1040 branches covered (72.12%)

Branch coverage included in aggregate %.

1084 of 1326 relevant lines covered (81.75%)

27.53 hits per line