stacklok / toolhive / 38437031082

71%

Build Type

push

github

Committed by web-flow

Commit Message

Record config-handler failures on the MCPRemoteProxy status (#6776)

* Record config-handler failures on the proxy status

The six error blocks in validateAndHandleConfigs wrote only
Status.Phase = Failed. No Message, no ObservedGeneration, and the Ready
condition was left untouched, so a proxy that was healthy and then lost
a referenced config reported both verdicts at once:

    phase: Failed
    message: Remote proxy is running
    observedGeneration: <last healthy generation>
    conditions:
      - type: Ready
        status: "True"

`kubectl wait --for=condition=Ready` and anything else keying on Ready
saw a healthy proxy while the operator had declared it Failed.

All six now go through markConfigHandlerFailed, which mirrors what the
other terminal paths in this controller already do (the embedded auth
config and CA bundle handlers): the phase, a message naming the handler
that failed, the observed generation, and Ready=False with reason
NotReady. The status update stays best effort, so a failure to persist
it is still logged rather than replacing the handler's own error.

The regression seeds a proxy with the status a healthy reconcile leaves
behind and drives each handler onto its not-found branch -- or, for
ExternalAuthConfig, onto the Valid=False mirror, because a *missing*
ExternalAuthConfig is rejected by spec validation before the handler
runs. All six cases fail against the previous controller: Ready stays
True and the observed generation stays on the seeded stale value.

One site with the same shape is deliberately not touched: the spec
validation path already sets Phase, Message and Ready=False, but leaves
Status.ObservedGeneration stale. Flagged in the PR rather than widened
here.

Validation: go test ./cmd/thv-operator/controllers/ passes; go vet and
gofmt clean. golangci-lint and task lint/test need go1.27, which this
machine refuses, so they were not run.

Signed-off-by: Chen Yufeiyang <fei76161@gmail.com>

* fix(operator): satisf... (continued)

Coverage Stats

19 of 19 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

86213 of 121041 relevant lines covered (71.23%)

126.62 hits per line