SAP / ui5-project / 38393060125

96%

main: 96%

push

github

[FIX] Restore merge key and timestamp support for js-yaml v5

js-yaml v5 defaults to CORE_SCHEMA (YAML 1.2), which drops the merge key
("<<:") and implicit timestamp support that v4's DEFAULT_SCHEMA provided.
A ui5.yaml that relies on merge keys would otherwise keep "<<" as a literal
mapping key instead of merging the referenced anchor.

Add lib/graph/helpers/ui5YamlSchema.js (CORE_SCHEMA extended with mergeTag
and timestampTag) and pass it as the schema when parsing configuration in
Module, graph, and createWorkspace. YAML11_SCHEMA is avoided on purpose: it
also changes scalar resolution (yes/no/on/off to boolean, 0-prefixed numbers
to octal).

Also switch Module and createWorkspace to the named loadAll import, since
js-yaml v5 no longer offers DEFAULT_SAFE_SCHEMA / a default export shaped
like v4.

Transferred from ui5-cli-sa commit cdc1153. The merge-key regression test is
adapted to the v4 project API (getCustomMiddleware/getCustomTasks instead of
getConfig).

1457 of 1560 branches covered (93.4%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 3 files covered. (100.0%)

2838 of 2927 relevant lines covered (96.96%)

129.64 hits per line