kubeflow / trainer / 38391878265

73%

master: 73%

Pull #3961

github

refactor: validate RuntimePatches after merge, remove duplicate checks

Changes based on mentor feedback:

Per-patch validation (ensure resources exist in template):
- Validate ReplicatedJob exists in runtime template
- Validate Container exists in runtime template
- Validate InitContainer exists in runtime template
- Validate no envs for reserved containers

Merged validation (after all patches applied):
- VolumeMount references existing volumes (after merge)
- VolumeMount mountPath is not empty
- Toleration operator is valid (Equal/Exists)
- Toleration effect is valid (NoSchedule/PreferNoSchedule/NoExecute)
- Toleration with Equal operator has value when key specified

Removed validations (handled by Kubernetes):
- Duplicate volume names (K8s listType=map prevents this)
- Duplicate volumeMount names (K8s listType=map prevents this)
- Duplicate tolerations (allowed per mentor feedback)
- Duplicate mountPaths (K8s handles this)
- Empty volume names (K8s validates this)

Tests:
- Updated 5 tests to reflect merged state in info.TemplateSpec.ObjApply
- Removed 3 tests for validations no longer performed
- All tests pass

Addresses feedback on #3893

Signed-off-by: Prateek Rai <prateekrai903@gmail.com>

56 of 62 new or added lines in 1 file covered. (90.32%)

3414 of 4682 relevant lines covered (72.92%)

0.85 hits per line