tari-project / tari / 38375892864

77%

Build Type

push

github

Committed by web-flow

Commit Message

fix(key_manager): low-impact hardening from the key manager security analysis (#8106)

## Description

This PR fixes the low-impact findings from the 2026-09-30 key manager
security analysis that were still open. Each commit covers one item.

- **Key-id length cap.**
- Key-id strings are capped at 1 KiB (`MAX_KEY_ID_LENGTH`). The cap is
checked first in `check_key_string`, so `from_str`, serde and borsh all
enforce it. The nesting cap of 16 came in earlier with #8077.
- The resolvers in the key manager now parse inner ids through one
helper, `parse_inner_key_id`. They still re-parse at every level,
because inner ids are stored as strings, but the two caps bound the
work.
- Every real key id is under about 420 bytes, so no stored key id is
rejected.
- **Zeroize decrypted keys.** `decrypt_encrypted_key` now wraps the
decrypted scalar bytes and the copy of the decryption key in
`Zeroizing`, so they are wiped on error returns too.
- **Ledger: refuse RevealedValue in
`get_metadata_signature_user_verified`.** The device always signs with a
random value nonce, but a RevealedValue output needs that nonce to be
zero, so consensus rejected these signatures with no local error. The
host now refuses them up front with `LedgerRevealedValueUnsupported`.
The script and sender-offset branch checks were already added by #8104.
- **Redact `Encrypted` ciphertexts in errors, logs and `Debug`.**
- `TariKeyId::redacted()` and `redact_key_id_string()` turn the hex of
every `encrypted.<hex>` segment into `encrypted.[N bytes]`. Malformed
strings are redacted too: the segment after `encrypted` and any other
hex run of 32 characters or more are hidden.
- `TariKeyId`, `SerializedKeyString` and the legacy key-id types now
have hand-written `Debug` impls that print the redacted form. That
covers `WalletOutput`, `DbWalletOutput`, `WalletOutputBuilder` and error
enums.
- The key-manager errors, the legacy conversion errors, the wallet
SQLite conversion errors and the pre-mine self-f... (continued)

Coverage Stats

323 of 377 new or added lines in 9 files covered. (85.68%)

47 existing lines in 15 files now uncovered.

123720 of 166709 relevant lines covered (74.21%)

1171987.76 hits per line