supabase / storage / 38373823126

86%

push

github

fix: accept quoted part ETags when completing file multipart uploads (#1503)

## Summary

Fixes #1502.

`CompleteMultipartUpload` includes the surrounding quotes in each part
`ETag` element. The file backend stored the part digest without quotes
and compared the two with `===`, so the documented form failed with
`InvalidChecksum` and the object was never assembled. Comparison now
uses the entity-tag value. A quoted or unquoted digest that does not
match the stored part is still rejected.

## Test plan

- [x] `src/storage/backend/file.test.ts` — a quoted ETag matching the
stored digest completes; a quoted ETag for a different digest still
returns `InvalidChecksum`; existing unquoted completion still passes
(111 tests)
- [x] `npm run lint`
- [x] `npm run build`
- [x] `git diff --check`
- [ ] Integration tests (`npm run test:integration`) require Docker and
Postgres and were not run

---------

Signed-off-by: Ferhat Elmas <elmas.ferhat@gmail.com>
Co-authored-by: Ferhat Elmas <elmas.ferhat@gmail.com>

7588 of 9424 branches covered (80.52%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

13244 of 14999 relevant lines covered (88.3%)

848.02 hits per line