hyperscale-stack / security / 38370418619

98%

master: 98%

Build Type

Pull #121

github

Committed by euskadi31

Commit Message

fix(oauth2): pin and correct the MySQL key upgrade

The upgrade test could not tell the documented orphan INSERT from one
missing either half of its UNION:
- without the refresh half, a revoked look-alike whose access token was
  gone is revived by a new issuance;
- without the access half, an access-only look-alike is revived.
It also missed the retention floor and the strict sql_mode.

The test now seeds both shapes and checks the inserted records
(revoked, kept for FamilyRevocationRetention at least). On a
connection whose own sql_mode is lax, it checks that a 66-byte family
ID stops the ALTER instead of being truncated. The conformance case
also tells apart token and code hashes that differ by a trailing
space.

MIGRATION.md: the instruction to stop token writes named the optional
step 3. It now targets step 2, between its families ALTER and its
INSERT, and only when the preflight counted merged tokens. It also
says that comparisons become exact table by table, and that the hex
display is the interactive mysql client's default.

Audit: STORE-I1.

Pull Request Pull Request #121: fix(stores)!: close the security audit findings of the SQL stores

Coverage Stats

123 of 123 new or added lines in 8 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

13857 of 14070 relevant lines covered (98.49%)

4907.06 hits per line