eclipse-aascw / aas-package3-golang / 38366581504

92%

push

github

Compare part names independent of percent-encoding (#16)

* Compare part names independent of encoding

The parts map was keyed by the raw ZIP entry name while FindPart used
the decoded url.URL.Path. A part stored under an OPC-conformant,
percent-encoded name such as aasx/suppl/a%20b.pdf could therefore not
be found, not even with its own Part.URI, and neither could parts with
a space that this library had written itself. Entries with a literal
space were renamed on Flush while their relationship targets kept the
literal name, which broke the package on a plain round trip.

ISO/IEC 29500-2 part names are URIs compared case-insensitively, so map
keys are now built from the decoded, lowercased and re-encoded path
segments, and URIs are keyed by their escaped path. Parts read from an
archive remember their entry name, which is reused on Flush, and
relationship parts are named after their source part instead of the
lowercased map key. PackageWriter now writes percent-encoded entry
names.

This mirrors eclipse-aascw/aas-package3-typescript#83.

* Fold only ASCII case and keep raw entry names

ISO/IEC 29500-2 compares part names as case-insensitive ASCII strings,
but strings.ToLower also folded non-ASCII characters after decoding, so
"%C3%84" (Ä) and "%C3%A4" (ä) collided and a package containing both was
rejected as having duplicate entries. Only A-Z are folded now.

Parts read from an archive stored the normalized path as entry name, so
entries with backslashes were still renamed on Flush. The raw ZIP entry
name is kept now; only a leading slash is dropped because archive/zip
requires relative entry names.

65 of 66 new or added lines in 1 file covered. (98.48%)

1447 of 1570 relevant lines covered (92.17%)

1581.58 hits per line