eclipse-aascw / aas-package3-typescript / 38366555754

90%

push

github

Compare part names independent of percent-encoding (#97)

* Compare part names independent of percent-encoding

The parts map was keyed by the raw ZIP entry name while lookups used the
percent-encoded URL pathname. A part whose entry name contains a literal
space (or another character URL encodes) could therefore not be found
via FindPart, not even with its own Part.URI, and DeletePart silently
did nothing. Flush also renamed such entries to their encoded form while
their relationship targets kept the literal name, which broke the
package on a plain open-and-flush round trip.

ISO/IEC 29500-2 part names are URIs compared case-insensitively, so map
keys are now built from the decoded, lowercased and re-encoded path
segments. Parts read from an archive remember their entry name, which
is reused on Flush, and relationship parts are named after their source
part instead of the lowercased map key.

Fixes #83

* Reject equivalent entries and fold only ASCII case

Two ZIP entries whose names differ only in percent-encoding or ASCII
case, e.g. "a b.pdf" and "a%20b.pdf", now map to the same part. Opening
such an archive used to keep only one of them and lose the other on
Flush, so it is now rejected as an invalid format, as the Go library
already does.

ISO/IEC 29500-2 compares part names as case-insensitive ASCII strings,
so non-ASCII characters are no longer case-folded: "%C3%84" (Ä) and
"%C3%A4" (ä) are distinct part names.

173 of 204 branches covered (84.8%)

Branch coverage included in aggregate %.

26 of 28 new or added lines in 1 file covered. (92.86%)

403 of 435 relevant lines covered (92.64%)

260.86 hits per line