hyperscale-stack / security / 38359255608

98%

master: 98%

Build Type

Pull #119

github

Committed by euskadi31

Commit Message

docs(oidc): scope the implicit-flow refusal to Provider.AuthorizeHandler

The docs said the OpenID Provider never serves the implicit flow, and
that its RFC 8414 metadata never advertises it. But only
Provider.AuthorizeHandler refuses AllowImplicit: a handler built from
Provider.Server().AuthorizeHandler, the path MIGRATION documents for
plain OAuth 2.0 requests approved by another ConsentFunc, still accepts
it. The server then serves the flow to those requests and advertises
it in its RFC 8414 metadata, while the discovery document does not,
which RFC 9068 §4 forbids.

The CHANGELOG, docs/oidc-provider.md, LIMITATIONS and MIGRATION
statements now apply to Provider.AuthorizeHandler. The Provider.Server
and AuthorizeHandler godoc, the provider docs, LIMITATIONS and the
MIGRATION path warn never to enable AllowImplicit on a handler built
from Server(): nothing refuses it there, and RFC 9700 §2.1.2 deprecates
the flow. No code changes, as decided (UD-1): a guard would need a new
oauth2 hook.

Audit: OAUTH-I4.

Pull Request Pull Request #119: fix(oauth2)!: harden the authorization server endpoints

Coverage Stats

394 of 394 new or added lines in 19 files covered. (100.0%)

1 existing line in 1 file now uncovered.

13313 of 13554 relevant lines covered (98.22%)

5085.55 hits per line