eclipse-aascw / aas-package3-golang / 38358002007

92%

main: 92%

Build Type

Pull #16

github

Committed by aaronzi

Commit Message

Compare part names independent of encoding

The parts map was keyed by the raw ZIP entry name while FindPart used
the decoded url.URL.Path. A part stored under an OPC-conformant,
percent-encoded name such as aasx/suppl/a%20b.pdf could therefore not
be found, not even with its own Part.URI, and neither could parts with
a space that this library had written itself. Entries with a literal
space were renamed on Flush while their relationship targets kept the
literal name, which broke the package on a plain round trip.

ISO/IEC 29500-2 part names are URIs compared case-insensitively, so map
keys are now built from the decoded, lowercased and re-encoded path
segments, and URIs are keyed by their escaped path. Parts read from an
archive remember their entry name, which is reused on Flush, and
relationship parts are named after their source part instead of the
lowercased map key. PackageWriter now writes percent-encoded entry
names.

This mirrors eclipse-aascw/aas-package3-typescript#83.

Pull Request Pull Request #16: Compare part names independent of percent-encoding

Coverage Stats

63 of 64 new or added lines in 1 file covered. (98.44%)

9 existing lines in 1 file now uncovered.

1429 of 1552 relevant lines covered (92.07%)

1455.49 hits per line