aio-libs / multidict / 38356582173

86%

push

github

Split _md_del_at_held() per table kind (#1789)

<!-- Thank you for your contribution! -->

## What do these changes do?

`_md_del_locked()` already runs one loop per table kind, yet the helper
it calls, `_md_del_at_held()`, took the kind as an argument and tested
it again. This splits it into `_md_del_at_held_compact()` and
`_md_del_at_held_anystr()`, which share `_removed_pairs_add()`, and
reduces `_md_del_matched()` to its watcher half, `_md_del_record()`, so
each loop calls the helper for its own kind. `_md_pop_all_matched()` on
the cold `popall()` path still picks one by kind. The pure-Python
backend has no equivalent and is unaffected.

The change is for readability: GCC already inlined both helpers into
every loop and folded the constant kind away, so the GIL `del d[key]`
rows do not move. Callgrind (`benchmarks/callgrind_driver.py
--include-multidict-only`, 3.14.7 and 3.14.7t, against master 85f331e2)
left 116 of 124 rows bit-identical; the ones that moved shifted through
block layout, listed below.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist: N/A, a refactor covered by the
existing suite
- [ ] Documentation reflects the changes: N/A
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`: N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests: `pytest -q` passed on 3.11.13 GIL C extension, debug build (4091
passed), and 3.11.13 pure Python with `MULTIDICT_NO_EXTENSIONS=1
--no-c-extensions` (1697 passed).
Inlining: `tools/check_inlining.py` ok on 3.14.7 and 3.14.7t.
Codegen: `tools/codegen_diff.py --ref 85f331e2` reports `_md_del_l... (continued)

842 of 1684 branches covered (50.0%)

Branch coverage included in aggregate %.

9799 of 10709 relevant lines covered (91.5%)

1.83 hits per line