solidjs / solid / 38319907174

78%

main: 89%

push

github

examples: todos-server works without JS; web: unchanged holes ship once (#3999)

* examples: todos-server renders whole for no-JS; fix HN and notes nits

todos-server streamed its list behind a Loading fallback, so a first load
without JavaScript never showed it. It now renders in the vite plugin's
async mode, and the README says so instead of claiming the list lands
before the first flush.

Both hackernews twins printed "ago ago" on thread pages (time_ago already
ends with it) and linked deleted comments to /users/undefined. The notes
sidebar chevron had its Expand/Collapse alt text swapped.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* examples: todos-server retries are forms, so they work without JS

The Retry controls under the list and beside the add field were buttons
with click handlers, dead on the no-JavaScript path that renders them from
the flash cookie. Each is now a form on the same action, built from the
failed submission's input; with JavaScript the router submits it like any
other form.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* examples: hackernews keeps the plain author link on deleted comments

The conditional link added a re-emittable hole per comment, and each one
is currently sent twice (1,376 extra records, about 216 KB on the big
thread). Deleted comments go back to linking /users/undefined until the
runtime stops re-sending unchanged holes.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* fix(web): do not re-send an unchanged hole that holds an addressed element

A markup hole's baseline compared without the lh comment markers but with
the data-lha addresses the first render writes on elements with dynamic
attributes. A sweep's re-evaluation mints none, so every such hole read as
changed and shipped a second time as a hole record on the document's live
channel: todos-server's whole list, each hackernews feed title.

Co-Authored-By: Claude Opus 5.5... (continued)

746 of 1036 branches covered (72.01%)

Branch coverage included in aggregate %.

1079 of 1321 relevant lines covered (81.68%)

27.07 hits per line