opendefensecloud / solution-arsenal / 38252565828

79%

Build Type

push

github

Committed by web-flow

Commit Message

fix(controller): requeue Targets when a bound Registry changes (#852)

## What
A change on a Registry now also requeues the Targets bound to it via
RegistryBinding, not only the ones using it as `renderRegistryRef`.

Part of #565.

## Why
`mapRegistryToTargets` only followed `renderRegistryRef` -> when a
provider changes `hostname` or rotates `targetPullSecretName` on a bound
Registry, the Targets keep their RenderTasks with the old pull secret
until something else happens to trigger a reconcile. Pre-existing, also
same-namespace, but with cross-ns RegistryBindings (#565) the provider
rotates secrets in its own ns and the user's Targets would never notice.

The map func now also lists the RegistryBindings in the Registry's
namespace via the existing `indexRegistryBindingByRegistryName` and
enqueues each binding's Target (`registryBindingTargetKey`, so
`targetRef.namespace` is followed). A failed list is logged and the rest
of the mapping keeps going. Duplicate requests are fine,
`EnqueueRequestsFromMapFunc` dedupes them per event.

## Testing
envtest, red first, then green:

```
make test testargs="--focus='targetPullSecretName.changes|mapRegistryToTargets' ./pkg/controller"
Ran 2 of 145 Specs -- 1 Passed | 1 Failed   (before the fix)

make test testargs="--focus='RegistryBinding|mapRegistryToTargets|cross-namespace.Registry' ./pkg/controller"
Ran 25 of 145 Specs -- 25 Passed | 0 Failed
```

The map func spec is the actual gate: it fails without the fix. The
envtest spec (rotate `targetPullSecretName`, RenderTask picks up the new
secret) also passed before the fix because another watch happened to
requeue the Target, so it covers the end-to-end behavior but not the
regression on its own. `go vet ./pkg/...` and `make lint` clean.

## Checklist
- [x] Tests added/updated (map func spec, pull secret rotation spec)
- [x] No breaking changes (or upgrade path documented above)
- [x] Readable commit history (squashed and cleaned up as desired)
- [x] AI code r... (continued)

Coverage Stats

9 of 11 new or added lines in 1 file covered. (81.82%)

4 existing lines in 2 files now uncovered.

5094 of 6475 relevant lines covered (78.67%)

39.99 hits per line