datatug / datatug-cli / 38240894458

100%

push

github

feat: persist optional SQLite comparison rows for paging (#252)

Adds optional server-private SQLite storage for comparison rows, allowing the browser to page matched, added, removed, and changed records without rerunning sources. POST comparison remains authoritative when cache setup, inserts, or commits fail; GET pages reauthorize both retained snapshots and require the original principal/policy fingerprint.

Paging closes its result set before touching metadata and returns the last included key as the exclusive cursor. Metadata and payloads share one SQLite read transaction so another server process cannot replace authorized rows between reads. Cache writes honor cancellation and logical byte bounds, with atomic TTL/LRU eviction; old cache schemas migrate to an empty fingerprint and require recomputation before reads.

Validation passed:
- `wb run -- go test ./pkg/comparecache -count=1 -timeout=30s`: paging without gaps or hangs, cancellation, bounded rollback, TTL/LRU, two-store replacement isolation, and rollback of partial TTL/LRU deletion.
- `wb run -- go test ./pkg/server/endpoints -run 'Test(ComputeCompare|CompareRows|LoadCompareRecord|ComparisonCache)' -count=1 -timeout=45s`: injected SQL insert failure, cap/cancellation fallback, and a narrowed policy that still replays snapshots successfully while denying the older cached secret column.
- `wb run -- golangci-lint run ./pkg/comparecache ./pkg/api ./pkg/server/endpoints ./pkg/server`: 0 issues; final store transaction adjustment also passed store-only lint.

Merged current main into the original PR branch, preserving current source and ACL validation. Managed commit/push hooks remain enabled. Independent review and authoritative CI gate landing.

Source commits:

- 8397280613bc feat: persist optional SQLite comparison rows for paging
  POST /datatug/compare now records observer rows into a private cache so GET /datatug/compare/rows can page matching and diff rows after re-authorizing both sn... (continued)

315 of 565 new or added lines in 6 files covered. (55.75%)

39724 of 41829 relevant lines covered (94.97%)

0.96 hits per line