supabase / supabase-flutter / 38223427918

92%

push

github

fix(storage): keep the trailing slash of the listPaginated prefix (#1943)

## What kind of change does this PR introduce?

Bug fix.

## What is the current behavior?

`listPaginated` runs the prefix through `_removeEmptyFolders`, which
strips a trailing `/`. The `object/list-v2` endpoint matches the prefix
as a plain string, the same way S3 does, so the trailing `/` changes the
result:

- With `withDelimiter: true`, `prefix: 'photos/'` is sent as `photos`.
The server then returns a single folder entry, `photos/`, plus any
object such as `photos.png`, instead of the contents of the `photos`
folder.
- Without a delimiter, `photos` also matches `photos.png` and
`photos-2/a.png`.

The storage server's own `object-list-v2` tests cover both cases:
`prefix without slash - with delimiter` expects `aal.txt` and the folder
`aal/`, and `prefix - with delimiter` uses `aal/` to list the folder
contents.

## What is the new behavior?

The prefix keeps its trailing `/`. Leading slashes are still removed and
repeated slashes are still collapsed, as for object paths. `list` is not
changed, because the `object/list` endpoint treats its prefix as a
folder.

## Additional context

`test/path_normalization_test.dart` has a new `listPaginated prefix`
group that replaces the `listPaginated` case in the per-path loop. Three
of its cases (`folder/`, `folder//`, and `//folder//sub//`) fail on the
previous code, and the `listPaginated posts options and parses the
result` test in `test/basic_test.dart` now expects `prefix/` to be sent
unchanged. The unit tests in `supabase_storage` pass, and `dart analyze`
and `dart format` are clean.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Corrected paginated storage listings to preserve trailing slashes in
folder prefixes while removing leading and repeated slashes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: ... (continued)

4 of 4 new or added lines in 1 file covered. (100.0%)

9498 of 10379 relevant lines covered (91.51%)

5.19 hits per line