stephenafamo / bob / 38203344148

53%

main: 53%

Build Type

Pull #783

github

Committed by jalaziz

Commit Message

fix!: use stable per-query aliases for Preload and multi-hop Joins

Preload and generated multi-hop Joins suffixed table aliases with the
process-global bob.NextUniqueInt counter, so building the same query
twice produced different SQL and defeated pgx prepared-statement caching
(#741).

Aliases now come from a counter on bob.Load (NextQueryAlias: bob_q0,
bob_q1, ...). Preloader.Apply passes the query's allocator to the
preload tree through the new orm.WithNextAlias option, and generated
multi-hop joins allocate intermediate aliases when applied. Preloaders
called without an allocator fall back to unique bob_g aliases.

Also fixes two Preload bugs found along the way:
- PreloadAs on multi-side relationships aliased every side, producing
  duplicate aliases; it now applies only to the final side.
- to_where columns were qualified with the parent table instead of the
  joined table, producing invalid or incorrect ON clauses.

BREAKING CHANGE: orm.Preloader now takes optional ...orm.PreloaderOpt
after parent. Calls such as loader("") still compile, but functions
declared with the old exact signature must add the variadic parameter.

Pull Request Pull Request #783: fix!: use stable per-query aliases for Preload and multi-hop Joins

Coverage Stats

30 of 30 new or added lines in 2 files covered. (100.0%)

7 existing lines in 1 file now uncovered.

12394 of 23180 relevant lines covered (53.47%)

733.44 hits per line