• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

valkyrjaio / valkyrja-php / 38196788698
100%

Build:
DEFAULT BRANCH: 26.x
Ran 12 Oct 2026 02:43AM UTC
Jobs 1
Files 1304
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

12 Oct 2026 02:41AM UTC coverage: 100.0%. Remained the same
38196788698

push

github

web-flow
[Http] fix!: Reject a route that names no handler (#1375)

# Description

A controller method that declared `#[Route]` and named no handler got a
route that answered
every request with an empty 200. The route attribute substituted a no-op
closure for the
missing handler, and the attribute route collector returned such a route
unchanged, so
nothing reported the mistake.

The attributes still substitute a default, because `Data\Route` requires
a handler and
nothing may build a route without one. The default is now
`NoRouteHandler`, an object a
caller can recognize, where two closures are never identical. The
collector reads the
handler from the `#[RouteHandler]` attribute or from the route
attribute's own `handler`
argument, and rejects the route when neither supplied one.

The failure names the route as well as the class and the method. One
method declares a
route for each route attribute it repeats, so the class and the method
alone would not say
which of those routes is at fault.

`NoRouteHandler` throws rather than answering. An empty response hides
the mistake behind a
valid reply, and a route built outside the collector keeps the stand-in.

Three test fixtures carried nine routes with no handler. They had
shipped unnoticed because
the old default hid them, and each one now names its handler.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [x] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [x] Documentation improvement

## Changes

- **`Http\Routing\Support\NoRouteHandler`** — added the stand-in that
each route attribute
substitutes for a handler the author did not name. It throws when a
request reaches it.
- **`Http\Routing\Attribute\Route`** and **`Attribute\DynamicRoute`** —
subst... (continued)

12 of 12 new or added lines in 4 files covered. (100.0%)

14220 of 14220 relevant lines covered (100.0%)

27.16 hits per line

Jobs
ID Job ID Ran Files Coverage
1 38196788698.1 12 Oct 2026 02:43AM UTC 1304
100.0
GitHub Action Run
Source Files on build 38196788698
  • Tree
  • List 1304
  • Changed 4
  • Source Changed 4
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #38196788698
  • 3635fb22 on github
  • Prev Build on 26.x (#38195775146)
  • Next Build on 26.x (#38197855646)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc