eclipse-aascw / aas-core-codegen / 38178357169

90%

push

github

Unify XML error paths across targets (#843)

The targets reported different paths for the same XML de-serialization
error. For example, a text instead of a number in the second item of
a set was reported as ``collection/numbers/*[1]`` in Python and Java,
``numbers/*[1]`` in C#, Go and TypeScript, and
``collection/numbers/*[1]/v`` in C++. We now report the same path,
``collection/numbers/*[2]``, in all six targets:

* The path starts with the root element, *e.g.*,
  ``something/someItems/*[1]``.
* The indices are 1-based as in XPath, ``*[i + 1]``. Only the rendering
  changes; the index segments stay 0-based, so the JSON paths are
  unchanged.

The readers do not prepend their own names anymore. Instead, the
property loop prepends the property, a class instance nested in
a property prepends its class element, and the containers prepend only
the index. For example, C++ reads the nested instances through
the new ``DeserializeNestedElement``, the counterpart of Python's
``_read_nested_element``, while Go and TypeScript wrap their readers in
``namingElement``.

An error which belongs to the container itself is reported at the
container, and not at an item which does not exist: text instead of
list items is reported at ``something/someItems``, and a missing tuple
item at ``something/pair``.

Go and TypeScript now skip the XML declaration before the root element,
and the C# tests move the reader to the content first. Previously, the
inputs with a declaration failed on it, and never reached the error
they were meant to test.

We add the live test data for an error in a class instance nested in
a list (``something/someItems/*[1]``) and in a property
(``something/structuralProperty/structuralFirst``).

32 of 32 new or added lines in 4 files covered. (100.0%)

45266 of 50217 relevant lines covered (90.14%)

2.7 hits per line