umputun / remark42 / 38166422441

84%

push

github

Fix the /web demo on instances that do not serve site remark (#2264)

* Fill the configured site into the demo pages the binary serves

The build emits the demo, counter and last-comments pages for site
remark. The docker image replaces that with the first configured site
at container start, but the binary served them as built, so on an
instance serving another site the demo's API requests failed with
"site not found" and its widget asked about a site the reader was not
signed in to.

The file server now fills in the first configured site the same way,
in the html files the docker image rewrites, and the site is part of
the cache validator so a changed SITE is not answered with 304. The
release build fails if those pages lose the site_id:"remark" literal
the server replaces and the docker image's pattern expects.

* Keep the session when a request is refused with 403

The fetcher cleared the auth cookies on 403 as well as 401. The server
answers 403 to a valid session that may not do something, such as one
issued for another site served from the same remark42 host, an
anonymous user, or a non-admin. Clearing the shared XSRF cookie then
could sign the reader out of the other sites using those cookies too.

Cookies are now cleared only on 401, which is what an invalid session
gets. Logout is the one place a 403 can mean the session is over: an
expired token sent as a header is refused there, so logout now forgets
the local session whatever the server answers.

* Finish signing out when the server refuses the logout

The logout request dropped the local session and then rejected, and
the signout action clears the signed-in user only after it resolves,
so a refused logout, such as an expired header token answered with 403,
left the widget showing the reader as signed in without credentials.
The request failure is now ignored once the session is dropped.

18 of 20 new or added lines in 3 files covered. (90.0%)

6086 of 7203 relevant lines covered (84.49%)

31.95 hits per line