node-opcua / node-opcua / 38118389972

91%

Build Type

push

github

Committed by erossignon

Commit Message

fix(address-space-store): the builder takes what findNode() returns

findNode() answers StoreNodeView | null, which addFolder, componentOf
and the other node references rejected, so callers cast it away or
wrote `?? undefined`, which turns a missing parent into an orphan node.

The builder now accepts null and throws an error naming the option,
never taking it as "no parent". Every reference is resolved before the
node is added, so an unknown or null parent no longer leaves a
half-created node behind.

Coverage Stats

34137 of 41895 branches covered (81.48%)

42 of 48 new or added lines in 2 files covered. (87.5%)

3 existing lines in 2 files now uncovered.

228324 of 249910 relevant lines covered (91.36%)

219692.97 hits per line