kettle-dev / kettle-family / 38081044471

88%

Build Type

push

github

Committed by pboling

Commit Message

✨ Pre-clean unreleased installs before release-mode bup

bup, bupb, and update-bundler now run a registry-driven pre-clean
(ReleasePreClean) before a release-mode re-resolution: installed gems
whose versions no registry publishes are removed, including
cross-family gems named in member lockfiles.

Previously the release-mode update only detected such pins after the
fact (PublishedVersionCheck) and its advice to re-run the update was
circular: bundler resolves against the local gem dir and >= floors
always re-pin the installed unreleased version. Removal up front turns
that opaque post-update failure into a resolved-before-it-mattered
cleanup. Fails open when the registry is unreachable. Self-removal of
kettle-family is expected and safe (subprocess uninstall).

Also names the actual fix in PublishedVersionCheck's diagnostic
message instead of the circular re-run advice.

Local-mode updates (deps-local, bup with local_path_env enabled)
intentionally skip the pre-clean.

Coverage Stats

2831 of 3629 branches covered (78.01%)

Branch coverage included in aggregate %.

48 of 51 new or added lines in 3 files covered. (94.12%)

1 existing line in 1 file now uncovered.

7065 of 7561 relevant lines covered (93.44%)

109.77 hits per line