kettle-dev / kettle-family / 38068840725

88%

Build Type

push

github

Committed by pboling

Commit Message

kettle-family: fix clean-blockers uninstall not holding

Two bugs in GemUninstallSupport, both found by the first real --execute
run (against kettle-rb's release blockers):

The batched gem uninstall aborted partway with Gem::DependencyRemovalException
when an installed gem OUTSIDE the batch depended on a batch member
(installed kettle-dev 3.1.9 depends on several blockers). Topological
ordering only covers dependents inside the batch. The cleanup now retries
once with --ignore-dependencies, re-batching only what survived the abort,
and records the escalation in stderr so the weaker guarantee is visible.

Worse, the cleanup did not hold at all: gem uninstall leaves
cache/<name>-<version>.gem behind, and the next bundle install
reinstalled the same unreleased versions from that cache without touching
the network -- all four gems removed by the first run were back after one
bundle install. The cleanup now removes the cached .gem files (including
platform variants) and verifies their absence alongside the installed
specifications.

New specs cover the retry (re-batch contents, escalation note, completed
removal), the no-retry case for non-dependency failures, and cache
removal including platform variants. Suite: 30 examples, 0 failures on
the two affected spec files.

Signed-off-by: Peter H. Boling <peter.boling@gmail.com>

Coverage Stats

2784 of 3573 branches covered (77.92%)

Branch coverage included in aggregate %.

22 of 22 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

6916 of 7406 relevant lines covered (93.38%)

108.25 hits per line