ponder-lab / Hybridize-Functions-Refactoring / #3363

88%

push

github

Process functions in file order, not hash order (#1042)

* Process functions in file order, not hash order

The processor grouped a project's functions with `Collectors.toSet()`
and built changes from another hash set. `Function.hashCode` hashes
the PyDev definition, so the order changed from run to run even with
parallel processing off. Analysis state that is first-come, such as
which function fixes a file's auto-injected import, then depended on
that order.

Functions are now sorted by project, file, line, definition ordinal,
and identifier before they are analyzed and before changes are built.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Pin the order changes are built in, not just the comparator

The test now reads the processor's optimizable functions over eight
definitions, so it fails if they come back in hash order.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

7 of 7 new or added lines in 1 file covered. (100.0%)

4803 of 5459 relevant lines covered (87.98%)

0.88 hits per line