samsarahq / taskrunner / 37995629781

41%

master: 41%

Pull #85

github

executor: restart KeepAlive tasks that exit cleanly

A KeepAlive task was only invalidated and restarted when its run ended
in an error state. A long-running task whose process is killed under a
wrapper that reports success for the killed child (for example, nx
exiting cleanly after the dev-server it launched is killed) surfaces to
the executor as a successful exit, so the task landed in the done state
and was never restarted, leaving the developer with a dead dev server
until the whole taskrunner was relaunched.

This contradicts the documented contract in the Task definition, which
promises that a KeepAlive task "will be restarted when it exits,
regardless of exit code". Invalidate the task on any exit of a
KeepAlive task instead of only error exits. The invalidation is a no-op
for a task canceled by taskrunner shutdown, since invalidate() ignores
canceled executions. Add a regression test covering the clean-exit
restart path.

8 of 8 new or added lines in 1 file covered. (100.0%)

845 of 2084 relevant lines covered (40.55%)

3.75 hits per line