adobe / aepsdk-rulesengine-typescript / 37992916762

88%

push

github

Normalize iam.action in historical event conditions (#36)

* Normalize iam prefixed fields in historical event conditions

AJO historical conditions can contain iam prefixed fields beyond iam.id and
iam.eventType, for example the "Show until click through" frequency rule:

  { "iam.eventType": "interact", "iam.action": "clicked", "iam.id": "..." }

Web SDK stores event history using non-prefixed field names
({ eventType, eventId, action }). normalizeEvent only renamed iam.id and
iam.eventType, so iam.action was hashed verbatim and never matched the stored
click. The historical count stayed at 0 and "until click through" messages
were shown again after being clicked.

Strip the iam. prefix from any remaining fields after the existing
eventType/eventId normalization. The prefixed value wins when both forms are
present, consistent with the existing iam.eventType handling.

* Limit historical event normalization to iam.action

Only rename iam.action to action instead of stripping the iam. prefix from
every field. Other iam prefixed fields are left in place, matching the
previous behavior for unknown fields.

---------

Co-authored-by: Jon Snyder <jonsnyder01@gmail.com>

211 of 220 branches covered (95.91%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

805 of 931 relevant lines covered (86.47%)

28.64 hits per line