solidjs / solid / 37984620700

77%

main: 89%

push

github

hydration: readShallow via ownKeys, store adapters ride the trace chunk, SC-only installs moved off hydrate() (#3904)

* size(web): readShallow reads a proxy's own keys directly

`readShallow` called `sourceKeys(value, SOURCE_PROXY)` for a proxy-backed
class/style object. By definition that is `Reflect.ownKeys(value)` (leafOf
is the identity for a non-memo kind; leafKeys answers SOURCE_PROXY with one
ownKeys trap), but the kind is a runtime argument the bundler cannot fold,
so the merge/omit view walkers of @solidjs/signals (collectKeys,
mergeKeysOf, hiddenByAny, isHidden, addKey, leafOf, viewSource — 1,076 B
minified) rode along on every compiled page with a dynamic class or style,
reached by nothing. Read the keys directly.

Measured (scripts/size, local): page: compiled base SC 109,461 → 108,296
min / 35,146 → 34,802 br; compiled live SC −1,165 / −375; app: compiled
hydrating +11 / −9 (keeps the walkers through spread()).

hydration-split-measured.md candidate (e).

* size(solid): store hydration adapters ride the trace chunk as their own copy

The store-family hydration adapters (createShadowDraft, quietAnswer,
hydrateStoreFromAsyncIterable, wrapStoreFn, hydrateStoreLikeFn,
hydrateStoreLike) move out of client/hydration.ts into
client/store-hydration.ts. enableHydration() still installs
hydrateStoreLike into the generic store slot (unchanged: a page with no
eager store wrapper shakes the install and the adapters with it), and
solid-js/internal/container-trace — the frames traces tier's
materializer, a lazy chunk — now bundles ITS OWN COPY of the module
(rollup: the adapter's ./hydration.js import resolves to the external
solid-js in that build) instead of reading the eager slot through
core.withStoreHydration. Reading the slot from the lazy chunk pinned
every adapter into the entry chunk of a server-component page that never
creates a client store: Rolldown assigns a module to the entry whenever
an eager module imports it, dead write or not (hydra... (continued)

746 of 1036 branches covered (72.01%)

Branch coverage included in aggregate %.

130 of 169 new or added lines in 4 files covered. (76.92%)

1079 of 1321 relevant lines covered (81.68%)

26.97 hits per line