solidjs / solid / 37966254622

77%

main: 89%

push

github

fix(web): surface a re-asked frame's error instead of re-asking forever (#3922)

* fix(web): surface a re-asked frame's error instead of re-asking forever

A server component that throws during render ships its error as the
sanitized message string. `landing()` told an error it had already
surfaced from the next flight's error by comparing payloads, so a
re-asked flight that failed the same way looked like the old error and
re-asked again: one request per flight with no end (about 3000/s in the
hackernews example after a hover preload of a failing route).

Key the surfaced error by the response version that carried it. Each
flight is a new version, so `reset()` and a fresh mount over an errored
address make one request and the error reaches the nearest `<Errored>`
again (or halts, with none).

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

* perf(web): trim the re-ask error keying in frames landing()

Fold the frame read, the version key and the surfaced check into one
helper that returns false / 1 (already surfaced: re-ask) / 2 (new: throw),
and let reask() chain the next landing itself. Same behaviour as the
version-keyed fix; 5 B smaller minified than next instead of +56 B.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(web): type the landing() error state comparison for strict test types

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

744 of 1033 branches covered (72.02%)

Branch coverage included in aggregate %.

1076 of 1317 relevant lines covered (81.7%)

27.18 hits per line