safe-global / safe-events-service / 37940403810

87%

push

github

fix: Remove DNS interceptor from webhook delivery (#629)

undici's interceptors.dns() (added in v1.6.0, #603) caused two issues:

- With the default dualStack: true it alternates IPv4 and IPv6 picks.
  Pods have no IPv6 egress, so about half of new connects to dual-stack
  hosts failed with ENETUNREACH. The interceptor only falls back to the
  other family on ETIMEDOUT/ECONNREFUSED, and the literal IP disables
  Node's happy eyeballs. RetryAgent then retried after 1s on IPv4.
- It keys pools by resolved IP, so hosts sharing an IP (Cloudflare)
  closed each other's connections on SNI change (servername changed).

Both made indexed APM error spans go from ~2M to ~25M a day.

Requests now target the hostname again. Keep-alive and clientTtl stay.
HTTP_DNS_CACHE_TTL and HTTP_DNS_CACHE_MAX_ITEMS are removed.

Also log the per-address errors when every address of a host fails, as
Node's AggregateError has an empty message.

Closes PLA-2121

80 of 89 branches covered (89.89%)

Branch coverage included in aggregate %.

690 of 788 relevant lines covered (87.56%)

10.22 hits per line