ponder-lab / Hybridize-Functions-Refactoring / #3335

88%

main: 88%

push

github

Count a global write as a side-effect wherever its value was created (#1035)

* Count a global write as a side-effect wherever its value was created

`filterSideEffects` dropped a `StaticFieldKey` write when every value written was created inside the function's closure, the rule it applies to locals. A global outlives the call, so `x = a + 1` under `global x` is a Python side-effect even though `a + 1` is allocated inside the function. Since Ariadne began allocating that sum in the function (wala/ML#932), the filter hid the write and `testPythonSideEffects42` and 45–49 lost their side-effect verdicts.

Ariadne also binds a nested `def`, class, or comprehension to a static field, named by its path under the enclosing code body (`global script A.py/f/g`), and that binding is scoped to the call. Only those keep the creation-site filter; a module-level global (`global x`) is now always kept.

`testPythonSideEffects70` stores a list created in the function into a global; it fails without the change on the pinned 0.52.104.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Keep a nested definition's defaults out of the global writes

A nested `def`'s defaults are bound with the definition, not to a module-level global, but Ariadne writes each to a static field of its own: the translator's `Lscript A.py/f/g_defaults_0`, and the parser's `g_default_0` (prefixed by the class for a method). Neither starts with `script `, so a default the function itself creates (`def g(y, z=[])` inside `f`) counted as a global write. Both spellings now keep the creation-site filter, like the definition's own binding.

`testPythonSideEffects71` covers the case; it fails without the change. A user global spelled like the parser's binding would be read as one, which the method's documentation states.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/sessio... (continued)

7 of 7 new or added lines in 1 file covered. (100.0%)

4791 of 5449 relevant lines covered (87.92%)

0.88 hits per line