google / OpenSK / 37924876944

97%

2.1: 97%

push

github

Use constant-time comparison for Hmac256 verification (#795)

WasefireEnv's Hmac256::verify and Hmac256::verify_truncated_left
compared MACs with standard slice/array equality (==), which is not
constant-time and violates the Hmac256 trait contract for verifying
PIN/UV authentication tokens and credential IDs.

Provide default implementations for verify and verify_truncated_left on
the Hmac256 trait using subtle::ConstantTimeEq, and use them in
WasefireEnv.

10 of 20 new or added lines in 2 files covered. (50.0%)

13707 of 14107 relevant lines covered (97.16%)

4287.61 hits per line