Eyevinn / mp4ff / 37912396622

83%

push

github

feat: take the tools' version from Go's build information

Since Go 1.24, building a package in a git checkout embeds the version from the tag: v0.60.0 at the tag, a pseudo-version such as v0.59.1-0.20261009092618-5f8fd3bc0bba after it, and +dirty for uncommitted changes, together with the commit time. internal.Version reads that with debug.ReadBuildInfo, as hi265 and livesim2 do, so a release no longer means editing internal/version.go, and a build between releases names its commit instead of the last release.

A build from a source archive has no git information and embeds no version. Homebrew builds that way, and so does MacPorts, through make with the git commands in the Makefile replaced by the release version. For them, Version falls back to commitVersion and commitDate, which are now empty unless set with -ldflags -X. The Makefile keeps its -X flags for that reason, but builds ./cmd/<tool> as a package, since a build of files embeds no version. goreleaser builds at the tag from a clean checkout, dist/ being ignored, so its -X flags are removed and its default ldflags apply.

The Homebrew formula must add the -X flag with the first release that has this change, or its test of -version fails.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

30 of 30 new or added lines in 11 files covered. (100.0%)

23868 of 28837 relevant lines covered (82.77%)

0.83 hits per line