panates / rman / 37906998338

95%

main: 95%

push

github

fix(clean): remove a symbolic link as a link, never follow it into another package

fast-glob follows links by default, so cleaning a build directory that
held build/node_modules/@scope/sibling - a link into another package's
build - deleted that package's output, then failed rmdir on the link
with ENOTDIR. Every glob in clean now says followSymbolicLinks: false
and a match is lstat'ed, so a link is removed and what it points at is
left alone.

A package clean fails on is also reported with no panel: the reason went
only into the item's log, which nothing replays without one, so a
build's nested rman clean said "0 succeeded, 1 failed" and no reason.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

4080 of 4452 branches covered (91.64%)

Branch coverage included in aggregate %.

42 of 42 new or added lines in 1 file covered. (100.0%)

22820 of 23923 relevant lines covered (95.39%)

252.71 hits per line