IgniteUI / igniteui-webcomponents / 37895778554

100%

push

github

fix: six bugs found while raising test coverage (#2460)

* fix: six bugs found while raising test coverage

Raise the test coverage of the source code to 99.77% lines, 98.96%
branches and 99.71% functions. The new tests cover the reachable gaps
in all components and internals. SSR-only branches are not tested.
The coverage report no longer counts the spec helpers in
src/internals/testing.

The fixes for the bugs that the tests found:

* color-picker: a negative or out-of-range HSV hue now wraps.
  ColorModel.fromHSV(-60, 100, 100) returned red, not magenta.
* calendar: a Weekdays or Weekends descriptor with a dateRange now
  disables the weekdays or the weekend days. Before, it disabled
  nothing.
* date-time-input, date-range-picker: ArrowUp, ArrowDown and the
  mouse wheel emit igcInput only when they change a date part. A
  spin with the cursor in a literal or in the range separator
  emitted igcInput with no change.
* draggable(), resizable(): a directive that first renders while
  disconnected now works after a reconnect. Before, it did nothing
  until the next render.
* chat: when the copy action fails, there is no unhandled promise
  rejection. The confirmation toast does not show.
* chat: the default attachment renderer no longer fails on an
  attachment with no name.

Remove dead code. The mask mixin no longer has _syncValueFromMask.
_commitMaskedValue is now the one method that each host implements.
Also remove the spellcheck toAttribute converter of igc-textarea,
which is never called because the property does not reflect, and an
lMin branch in the color converters that cannot run.

* test(color-picker): sample property-test colors on a grid, check hue wrap

Add a property test: an HSV hue gives the same RGB color after any
whole number of full turns.

Generate the RGB, HSL and HSV colors of the property tests on a 0.1
grid. Most fc.double samples are near 0, which gives blacks and grays
where the channels and the hue do not show, so the pr... (continued)

8312 of 8399 branches covered (98.96%)

Branch coverage included in aggregate %.

48 of 48 new or added lines in 8 files covered. (100.0%)

52375 of 52496 relevant lines covered (99.77%)

2963.12 hits per line