astronomer / astro-cli / 37871368360

45%

Build Type

push

github

Committed by web-flow

Commit Message

Clear the refresh token on logout and stop failing silently (#2218)

* Clear the refresh token on logout, not just the access token

astro logout cleared the access token and email but left the refresh
token in ~/.astro/config.yaml. That token is still a live credential:
it can be exchanged with Auth0 for a fresh access token, so a user who
believed they were logged out still had a working session on disk.

Logout now clears the refresh token alongside the access token and
email. It also now returns an error instead of returning silently when
a field fails to clear, and skips the "Successfully logged out"
message on that path, so a partial logout is visible instead of
looking clean. The one caller (cmd/auth.go's logout) now returns that
error up to cobra, which was a small enough change to make rather than
keeping the fix message-only.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Clear logout credentials in one write, and only for a domain logged into

Review follow-ups on the logout fix:

- Clear the token, refresh token, email and expiry in one config write
  (config.Context.ClearCredentials), so a save that fails leaves the
  context as it was rather than with the refresh token still in place,
  and the token's expiry is no longer left behind.
- Fail on a domain with no login instead of writing a stub context for
  it and reporting success while the real credentials stay on disk.
- Reset the current context only when the logged-out domain is the
  current one, so logging out of another domain keeps the selection.
- Return wrapped errors instead of printing a line and returning the
  bare error, which cobra then printed a second time without context.
- Use a local err instead of the package-level one, and correct the
  doc comment, which described a registry logout this does not do.

Tests now cover each of these, including that logout returns
cloudLogout's error; the old partial-failure case used an empty domain
and never reached a se... (continued)

Coverage Stats

12 of 27 new or added lines in 3 files covered. (44.44%)

1 existing line in 1 file now uncovered.

27012 of 60136 relevant lines covered (44.92%)

9.67 hits per line